Fixing coverity + documentation

openfpm_data @ 746121a6

-Subproject commit a7232f77b60b8716f82abee2c1606f1a01c5dbfb
+Subproject commit 746121a6040445dc58fc02d1d2bb056fe26dc33e

openfpm_devices @ 2da3b22b

-Subproject commit 818a07d2fc16e69e4b3c47955a8e22373f5bd0f4
+Subproject commit 2da3b22b477d8b94b60fb9eb5f1a4daacb6857b5

openfpm_io @ fac23ddd

-Subproject commit 863d65e6f3e7c9af1e979a78d2eae8aed332a81f
+Subproject commit fac23ddd992dc17d82904bd5083f5235416c2255

openfpm_numerics @ 858741a6

-Subproject commit 4cbdaaa7e37d236b598c130187170559d07d94c3
+Subproject commit 858741a69309557a0dd77bd3f99d581564885e7e

openfpm_vcluster @ a9991812

-Subproject commit 046f18aafb2275ed0d6fcdfba0c99daded20dc46
+Subproject commit a99918127f5835c31d2df4e9020efdeb46d07d66

src/Decomposition/CartDecomposition.hpp

@@ -379,7 +379,10 @@ public:
 
 		// multiply for sub-sub-domain side for each domain
 		for (size_t i = 2; i < dim; i++)
+		{
+			/* coverity[dead_error_line] */
 			gh_v *= b_s;
+		}
 
 		size_t norm = (size_t) (1.0 / gh_v);
 
@@ -758,7 +761,8 @@ public:
 		cart.gr = gr;
 		cart.cd = cd;
 		cart.domain = domain;
-		std::copy(spacing,spacing+3,cart.spacing);
+		for (size_t i = 0 ; i < dim ; i++)
+		{cart.spacing[i] = spacing[i];};
 
 		cart.bbox = bbox;
 		cart.ghost = g;
@@ -796,7 +800,8 @@ public:
 		cart.gr = gr;
 		cart.cd = cd;
 		cart.domain = domain;
-		std::copy(spacing,spacing+3,cart.spacing);
+		for (size_t i = 0 ; i < dim ; i++)
+		{cart.spacing[i] = spacing[i];};
 
 		cart.ghost = ghost;
 
@@ -827,7 +832,9 @@ public:
 		gr = cart.gr;
 		cd = cart.cd;
 		domain = cart.domain;
-		std::copy(cart.spacing,cart.spacing+3,spacing);
+
+		for (size_t i = 0 ; i < dim ; i++)
+		{spacing[i] = cart.spacing[i];};
 
 		ghost = cart.ghost;
 
@@ -858,7 +865,8 @@ public:
 		gr = cart.gr;
 		cd = cart.cd;
 		domain = cart.domain;
-		std::copy(cart.spacing,cart.spacing+3,spacing);
+		for (size_t i = 0 ; i < dim ; i++)
+		{spacing[i] = cart.spacing[i];};
 
 		ghost = cart.ghost;
 
@@ -868,8 +876,6 @@ public:
 			bc[i] = cart.bc[i];
 
 		return *this;
-
-		return *this;
 	}
 
 	/*! \brief The default grid size

src/Decomposition/CartDecomposition_ext.hpp

@@ -221,7 +221,9 @@ public:
 		this->domain = ext_domain;
 
 		// spacing does not change
-		std::copy(dec.spacing,dec.spacing+3,this->spacing);
+
+		for (size_t i = 0 ; i < dim ; i++)
+		{this->spacing[i] = dec.spacing[i];};
 
 		this->ghost = g;
 		this->dist = dec.dist;

src/Decomposition/Distribution/metis_util.hpp

@@ -231,6 +231,7 @@ public:
 		Mg.options = NULL;
 		Mg.objval = NULL;
 		Mg.part = NULL;
+		Mg.vsize = NULL;
 	}
 
 

src/Graph/ids.hpp

@@ -20,24 +20,51 @@ struct rid
 	//! id
 	idx_t id;
 
-	//! Cosntructor
+	/*! \brief Cosntructor from id
+	 *
+	 * \param id
+	 *
+	 */
 	rid(size_t id)
 	:id(id)
 	{}
 
 	//! Constructor
-	rid()	{}
+	rid()
+	:id(0)
+	{}
 
+	/*! \brief Compare two gid
+	 *
+	 * \param r gid to compare with
+	 *
+	 * \return the result for comparation
+	 *
+	 */
 	inline bool operator<=(const rid & r) const
 	{
 		return id <= r.id;
 	}
 
+	/*! \brief Compare two gid
+	 *
+	 * \param r gid to compare with
+	 *
+	 * \return the result for comparation
+	 *
+	 */
 	inline bool operator<(const rid & r) const
 	{
 		return id < r.id;
 	}
 
+	/*! \brief Subtract two gid
+	 *
+	 * \param i
+	 *
+	 * \return itself
+	 *
+	 */
 	inline rid operator-(int i) const
 	{
 		struct rid tmp;
@@ -45,6 +72,13 @@ struct rid
 		return tmp;
 	}
 
+	/*! \brief Subtract two gid
+	 *
+	 * \param i gid to subtract
+	 *
+	 * \return itself
+	 *
+	 */
 	inline rid operator-(struct rid i) const
 	{
 		struct rid tmp;
@@ -52,6 +86,13 @@ struct rid
 		return tmp;
 	}
 
+	/*! \brief Sum two gid
+	 *
+	 * \param i gid to subtract
+	 *
+	 * \return itself
+	 *
+	 */
 	inline rid operator+(int i) const
 	{
 		struct rid tmp;
@@ -59,12 +100,24 @@ struct rid
 		return tmp;
 	}
 
+	/*! \brief Sum two gid
+	 *
+	 * \param i gid to sum
+	 *
+	 * \return itself
+	 *
+	 */
 	inline rid & operator+=(const rid & i)
 	{
 		id += i.id;
 		return *this;
 	}
 
+	/*! \brief Increment the id
+	 *
+	 * \return itself
+	 *
+	 */
 	inline rid & operator++()
 	{
 		id++;
@@ -72,6 +125,13 @@ struct rid
 		return *this;
 	}
 
+	/*! \brief compare two ids
+	 *
+	 * \param r id to check with
+	 *
+	 * \return the result
+	 *
+	 */
 	inline bool operator==(const rid & r) const
 	{
 		return id == r.id;

src/Grid/grid_dist_id_unit_test.cpp

@@ -35,6 +35,7 @@ BOOST_AUTO_TEST_CASE( grid_dist_id_domain_grid_unit_converter3D_test)
 
 	long int k = 293;
 	long int big_step = k / 30;
+	/* coverity[dead_error_line] */
 	big_step = (big_step == 0)?1:big_step;
 	long int small_step = 21;
 

src/Vector/vector_dist_key.hpp

@@ -67,6 +67,7 @@ public:
 	//! Default constructor
 	inline vect_dist_key_dx()
 	{
+		/* coverity[uninit_member] */
 	}
 
 	//! Default constructor